Conditions #9
Merged
Conditions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages need work. Also need to check for circular lists and some other stuff.
Some of the error messages they signal are pretty bad, but an unclear error is preferable to silently accepting invalid code. Also, testing error messages might be awkward, because I'd like to let clients do the thing where invalid code is replaced by a "compiler failed on this" form, so COMPILE still returns a function. If they want. Eventually. Still need to test circular lists but ehhhhh.
For special forms at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better errors when the compiler is given syntactically invalid code.
There's more to be done cleaning things up, and probably some work should go into the
compile-fileend of things.