Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement ICU shared machinery when it becomes mandatory #266

Closed
GoogleCodeExporter opened this issue Aug 9, 2015 · 12 comments
Closed

implement ICU shared machinery when it becomes mandatory #266

GoogleCodeExporter opened this issue Aug 9, 2015 · 12 comments

Comments

@GoogleCodeExporter
Copy link
Contributor

ld: bl out of range (-17524756 max is +/-16M) from _MOZ_ReportAssertionFailure 
at 0x049742E8 in __text_cold of ../../xpcom/base/ClearOnShutdown.o to 
_fprintf$LDBL128$stub$island$5 at 0x038BDB20 in __text of  XUL in 
_MOZ_ReportAssertionFailure from ../../xpcom/base/ClearOnShutdown.o
collect2: ld returned 1 exit status
gmake[1]: *** [XUL] Error 1

This is very bad.

Original issue reported on code.google.com by [email protected] on 23 Mar 2014 at 7:23

@GoogleCodeExporter
Copy link
Contributor Author

This didn't happen in 26, and ICU is known to bloat the build substantially ( 
https://bugzilla.mozilla.org/show_bug.cgi?id=853301 ). Let's build without it.

Original comment by [email protected] on 23 Mar 2014 at 9:13

@GoogleCodeExporter
Copy link
Contributor Author

OK, that links. So that buys us some time until --with-intl-api becomes 
mandatory (it isn't yet because Android and B2G don't support it either).

Original comment by [email protected] on 23 Mar 2014 at 11:52

@GoogleCodeExporter
Copy link
Contributor Author

Release builds should be smaller, shouldn't they?
Even if not one can still dynamically link against ICU.

Original comment by [email protected] on 24 Mar 2014 at 5:29

@GoogleCodeExporter
Copy link
Contributor Author

They should be, but I haven't tried, and I still need a debug build.

Mozilla builds ICU static. They are working on something to spin out the .dat 
file which right now is linked in too, so that could help (right now the Mac 
version has two copies, one for x86 and one for x64, which bloats XUL further).

Original comment by [email protected] on 25 Mar 2014 at 5:20

@GoogleCodeExporter
Copy link
Contributor Author

And it looks like we're not the only one to hit this with ICU:
http://tug.org/pipermail/tlbuild/2012q1/002109.html

Original comment by [email protected] on 25 Mar 2014 at 5:22

@GoogleCodeExporter
Copy link
Contributor Author

Well, I take that back. They do still support building a shared ICU; I thought 
it had bitrotted: https://bugzilla.mozilla.org/show_bug.cgi?id=926980

Original comment by [email protected] on 25 Mar 2014 at 1:21

@GoogleCodeExporter
Copy link
Contributor Author

We want to fix this eventually, but this is no longer critical.

Original comment by [email protected] on 5 Jul 2014 at 1:15

  • Added labels: Priority-High
  • Removed labels: Priority-Critical

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by [email protected] on 15 Jun 2015 at 9:25

  • Changed title: implement ICU shared machinery when it becomes mandatory
  • Added labels: Priority-Medium
  • Removed labels: Priority-High

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by [email protected] on 2 Jul 2015 at 3:48

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by [email protected] on 29 Jul 2015 at 3:57

@GoogleCodeExporter
Copy link
Contributor Author

Also added a stub normalize() for some addons that require it.

Original comment by [email protected] on 29 Jul 2015 at 3:57

@classilla
Copy link
Owner

Fixed by issue 304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants