Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert minimp3 to platform decoder #325

Closed
classilla opened this issue Sep 10, 2016 · 5 comments
Closed

Convert minimp3 to platform decoder #325

classilla opened this issue Sep 10, 2016 · 5 comments

Comments

@classilla
Copy link
Owner

Regression from 38, but MP3 playback goes through a different pathway we should try to leverage in 45 and we should just convert minimp3 to that.
@classilla
Copy link
Owner Author

It doesn't (fully), but it does help, and it fixes other glitches.

@classilla
Copy link
Owner Author

The new Amazon code drop seems to have completely broken us in other ways. No idea why.

@classilla classilla changed the title See if converting minimp3 to a platform decoder fixes Amazon Music Convert minimp3 to platform decoder Nov 12, 2016
@classilla
Copy link
Owner Author

Still works fine in 38.

@classilla
Copy link
Owner Author

Also occurs in 40.0.3, so that narrows the regression range. We'll need a tool to actually profile the browser to figure out where it spends its time (Shark dies on symbol resolution), so let's just narrow this bug to the platform decoder (which is working).

@classilla
Copy link
Owner Author

Shipp'd (the platform decoder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@classilla