Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for more mismatched PRIu64 - PRId64 usage #346

Closed
classilla opened this issue Jan 25, 2017 · 1 comment
Closed

Audit for more mismatched PRIu64 - PRId64 usage #346

classilla opened this issue Jan 25, 2017 · 1 comment

Comments

@classilla
Copy link
Owner

Due to clashing definitions with 10.4's /usr/include/inttypes.h we were using the wrong PRI*64 macros for the libgcc included with gcc 4.8, which caused some printfs to fail. This caused a very hard to diagnose failure in JavaScript code coverage, among other places. This is now corrected in mfbt/IntegerPrintfMacros.h but we need to check that this is actually being used rather than the now defective macro in the original <inttypes.h>.

Here's a set of candidates for PRIu64:

bruce:/home/spectre/src/bruce/esr45m/% grep -rsl PRIu64 * | fgrep '.cpp'
dom/base/nsPerformance.cpp
dom/devicestorage/nsDeviceStorage.cpp
dom/ipc/ProcessPriorityManager.cpp
dom/media/ADTSDemuxer.cpp
dom/media/MP3Demuxer.cpp
dom/media/webm/WebMDemuxer.cpp
dom/media/webrtc/MediaEngineRemoteVideoSource.cpp
gfx/layers/apz/src/APZCTreeManager.cpp
gfx/layers/apz/src/HitTestingTreeNode.cpp
gfx/layers/apz/src/InputQueue.cpp
gfx/layers/apz/util/APZCCallbackHelper.cpp
gfx/layers/apz/util/APZEventState.cpp
gfx/layers/ipc/CompositorParent.cpp
gfx/layers/LayersLogging.cpp
js/src/devtools/gctrace/gcstats.cpp
js/src/gc/Nursery.cpp
js/src/jit/arm64/vixl/Debugger-vixl.cpp
js/src/jit/arm64/vixl/Instrument-vixl.cpp
js/src/jit/SharedIC.cpp
js/src/vm/CodeCoverage.cpp
layout/base/ZoomConstraintsClient.cpp
media/webrtc/signaling/src/media-conduit/WebrtcOMXH264VideoCodec.cpp
mfbt/tests/TestIntegerPrintfMacros.cpp
mozglue/linker/ElfLoader.cpp
widget/gonk/nativewindow/GonkBufferQueueLL/GonkBufferQueueConsumer.cpp
widget/gonk/nativewindow/GonkBufferQueueLL/GonkBufferQueueCore.cpp
widget/gonk/nativewindow/GonkBufferQueueLL/GonkBufferQueueProducer.cpp
widget/gonk/nativewindow/GonkConsumerBaseLL.cpp
xpcom/base/nsTraceRefcnt.cpp
xpcom/ds/nsSupportsPrimitives.cpp
@classilla
Copy link
Owner Author

All areas audited and fixed as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant