OlgaTPark/tenfourfox#14 — Allow saving passwords in private windows with a dismissed-by-default doorhanger #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a dismissed-by-default doorhanger and fix preferences accordingly Testcases aren't included because they require async/await. References: https://bugzilla.mozilla.org/show_bug.cgi?id=1520960 (Allow saving passwords in private windows with a dismissed-by-default doorhanger) https://hg.mozilla.org/mozilla-central/rev/b4645dc802f9 (Allow login capture from form submissions in private browsing when pref'd on.) https://hg.mozilla.org/mozilla-central/rev/5656f8b5c547 (Allow login capture from HTTP auth prompts in private browsing when pref'd on.) https://bugzilla.mozilla.org/show_bug.cgi?id=1660998 (Option to save logins does not keep state in private mode) https://hg.mozilla.org/mozilla-central/rev/d67d3463b4aa (Don't disable the password manager checkbox in permanent private browsing mode.)
|
Seems straightforward enough. Thanks! Good to see you again. Sorry for the delay, I wanted to land some other work first to ensure it wouldn't conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello (if you ever remember that I've existed at some point in time),
Here are the changes allowing to save passwords in private browsing and the M1660998 fix for the
Remember logins for sitesinabout:preferences#security. Useless details are uselessly present in the useless commit comment (did I noted it's useless?). Both were locally tested in OlgaFox FPR7 and FPR8. (Somewhat later than what I've announced to let you rest during end-of-year, as requested, plus other delays on my side…)Of course, implementing this can wait the next beta cycle of TenFourFox and I personally prefer to see this change in a beta build prior a release one, just to be really sure that everything is OK.
Anyway, happy browsing (since « Happy new year » would be too late) and sorry for the silence!