Private method for SDF internals #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors to reduce copies into numpy arrays, and use vecs of vecs less.
So that it is actually signed. Also some documentation.
|
OK this is definitely not returning the correct thing yet, misunderstood some parry docs. |
|
Should be correct now. Because parry has separate features for backfaces, the norms all face inwards and so all the dot products are negative, but I think just calling |
|
This spiralled a bit and now resolves #45 too. |
No it doesn't, but is superceded by #36 , which does 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only serial for nowandcompletely untested (could very much be returning the wrong thing at present)only a little bit tested. See #33