Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining reference to MIXED_ADDITION macro #52

Open
dtebbs opened this issue Jun 17, 2021 · 0 comments
Open

Remove remaining reference to MIXED_ADDITION macro #52

dtebbs opened this issue Jun 17, 2021 · 0 comments

Comments

@dtebbs
Copy link
Contributor

dtebbs commented Jun 17, 2021

USE_MIXED_ADDITION was used in several contexts, controlling both the assumed form of base elements in multiexp, AND and some cases whether or not to batch-convert intermediate values to special form.

#45 allows the input base elements to be specified as a (template) parameter, but the macro is still used in the BDL012 implementation of multiexp. This would be better handled as some kind of parameter (a new method BDLO12_... or another template parameter, which could apply in several situations, such a BDLO12_signed).

With this, it should be possible to remove the macro and CMake parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant