You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code base has recently been formatted with clang-format using the same styling guide as the one in Zeth (see #48).
As a next step, it would be good to run clang-tidy on the code base to enforce best practices and catch potentially problematic code patterns. However, as opposed to clang-format which simply formats code, clang-tidy suggests code changes. As such, extra care needs to be allocated when using clang tidy. Rather than using the same config as in Zeth and run clang-tidy --fix (which could trigger an enormous amount of changes in the code, making the associated PR very painful to review.. effectively increasing risks of unexpected code behavior/bug), it is preferable to take an incremental approach and support a subset of checks from the Zeth clang-tidy config that doesn't shuffle the code too much.
The text was updated successfully, but these errors were encountered:
The code base has recently been formatted with
clang-format
using the same styling guide as the one in Zeth (see #48).As a next step, it would be good to run
clang-tidy
on the code base to enforce best practices and catch potentially problematic code patterns. However, as opposed toclang-format
which simply formats code, clang-tidy suggests code changes. As such, extra care needs to be allocated when using clang tidy. Rather than using the same config as in Zeth and runclang-tidy --fix
(which could trigger an enormous amount of changes in the code, making the associated PR very painful to review.. effectively increasing risks of unexpected code behavior/bug), it is preferable to take an incremental approach and support a subset of checks from the Zeth clang-tidy config that doesn't shuffle the code too much.The text was updated successfully, but these errors were encountered: