Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the curve equation checking functions and tests #76

Open
AntoineRondelet opened this issue Apr 28, 2022 · 0 comments
Open

Polish the curve equation checking functions and tests #76

AntoineRondelet opened this issue Apr 28, 2022 · 0 comments

Comments

@AntoineRondelet
Copy link
Contributor

See: thread #68 (comment)

More specification, as mentioned by @dtebbs in #68 (comment), we need to:

  • Tests for the is_well_formed method (generate negative tests cases by just addign 1 to the Y coord, etc)
  • Whether to use is_well_formed to check curve points on read? (since it will generally be faster) (remembering that we should also have a flag for this)
  • Whether to use a generic equation-checking function in the main body? (in fact some implementations of is_well_formed may be able to reuse it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant