Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Withdraw checks possible enhancement #46

Open
magooster opened this issue Jan 10, 2018 · 1 comment
Open

Withdraw checks possible enhancement #46

magooster opened this issue Jan 10, 2018 · 1 comment

Comments

@magooster
Copy link

Within the Mixer contracts Withdraw function the signature is checked for validity, including checking for the existence of the tag, then the 'tag' is added to ensure the same signer doesn't attempt to withdraw again.

Would this not be more readable if this were split into two checks, one where we require the signature tag not to already exist and the second to validate the signature.

require (AddTag)
require (SignatureValid)

The AddTag function would check for the existence of the tag, and return false if tag already exists or add and return true if it doesn't. This would also be consistent with the AddParticipant logic in the Deposit function.

@HarryR
Copy link
Contributor

HarryR commented Jan 10, 2018

Yup, makes sense.

Higher priority is ERC-223 support and making Wallet software more usable / easy to integrate.

Can the Mixer be more easily abstracted multiple frontends which supports ERC-20, ERC-223 and Ether without duplicating code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants