You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Within the Mixer contracts Withdraw function the signature is checked for validity, including checking for the existence of the tag, then the 'tag' is added to ensure the same signer doesn't attempt to withdraw again.
Would this not be more readable if this were split into two checks, one where we require the signature tag not to already exist and the second to validate the signature.
require (AddTag)
require (SignatureValid)
The AddTag function would check for the existence of the tag, and return false if tag already exists or add and return true if it doesn't. This would also be consistent with the AddParticipant logic in the Deposit function.
The text was updated successfully, but these errors were encountered:
Within the Mixer contracts Withdraw function the signature is checked for validity, including checking for the existence of the tag, then the 'tag' is added to ensure the same signer doesn't attempt to withdraw again.
Would this not be more readable if this were split into two checks, one where we require the signature tag not to already exist and the second to validate the signature.
require (AddTag)
require (SignatureValid)
The AddTag function would check for the existence of the tag, and return false if tag already exists or add and return true if it doesn't. This would also be consistent with the AddParticipant logic in the Deposit function.
The text was updated successfully, but these errors were encountered: