Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password resets for non-Clef users via override url when disable passwords for all users = true #235

Open
lolux opened this issue Mar 4, 2016 · 0 comments

Comments

@lolux
Copy link
Contributor

lolux commented Mar 4, 2016

User report: https://wordpress.org/support/topic/reset-password-lnot-working-anymore

Behavior confirmed in version 2.4.0. To reproduce:

  1. Turn on password disabling for all users
  2. Enable override URL
  3. For a non-Clef-enabled WP user, attempt to perform a password reset via the override url
    1. Expected result: successful password reset
    2. Actual result: user receives error: “Password reset is not allowed for this user”

Also confirmed in prior versions (i.e., 2.4.0 did not introduce a bug). If I recall, back when the force Clef and override URL features were added (~ version 1.7), we chose not to allow password resets, even at the override URL, when disable passwords for all users was turned on. The reasoning behind this decision involved reducing the attack vector from malicious password reset requests (i.e., account takeover via email account breach).

There's room to discuss whether it makes sense to add add the ability to perform password resets via the override URL.

@lolux lolux changed the title Password reset for non-Clef users via override url not working Add password resets for non-Clef users via override url when disable passwords for all users = true Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant