Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read from {mdl}.json file instead of yaml in create package #357

Open
chrispcampbell opened this issue Sep 21, 2023 · 0 comments
Open

Read from {mdl}.json file instead of yaml in create package #357

chrispcampbell opened this issue Sep 21, 2023 · 0 comments

Comments

@chrispcampbell
Copy link
Contributor

I found this code and comment in the create package in step-config.ts:

  // Read `build/{mdl}_vars.yaml`
  // TODO: For now the printVarList code only outputs txt and yaml files; we'll use the
  // yaml file for now, but that means we have a dependency on the `yaml` package.  Once
  // we change the `compile` package to output JSON, we'll need to change this code.
  const varsYamlFile = joinPath(buildDir, `${mdlName}_vars.yaml`)
  const varsYamlContent = await readFile(varsYamlFile, 'utf8')
  const varObjs = yaml.parse(varsYamlContent)

We are about to have the JSON file available as an alternative to the YAML one (see #105). Once those changes land, we can update the above code to read from {mdl}.json, and we can drop the yaml package dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant