Hardcoded path ~/Dropbox for some directories

[yuchdev]

I don't have Dropbox and never did.
My backup directory is configured at startup:
export MACPREFS_BACKUP_DIR=/Users/username/.macprefs
However, some directories are being created in ~/Dropbox (the directory Dropbox is being created):

app_store_preferences
dotfiles
preferences
shared_file_lists
ssh
StartupItems
system_preferences

I manually moved them into the directory I configured, but now I'm concerned, if the restore function also has hardcoded paths.

[tillydray]

That stinks! If I had to guess I'd say your MACPREFS_BACKUP_DIR got unset somehow, then MacPrefs ran. According to readme.md#config Dropbox is the default location for the backup_dir, so when MACPREFS_BACKUP_DIR was unset it used Dropbox.

I'm not sure how frequently MacPrefs runs, and I'm not sure how your MACPREFS_BACKUP_DIR got unset, but my theory is the only one I have right now.

[yuchdev]

I don't know how it may become unset during the script execution. export MACPREFS_BACKUP_DIR is being set among other variables in .zshrc. My guess is hardcoded path somewhere.