-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clojure-ts-mode support #215
base: master
Are you sure you want to change the base?
Conversation
0463f1f
to
12e9c9d
Compare
Add support to `clojure-ts-mode`, a Clojure major mode that uses tree-sitter. For more details on `clojure-ts-mode`, consult its repository [0]. [0]: https://github.com/clojure-emacs/clojure-ts-mode.
12e9c9d
to
7d91b92
Compare
I think it may be prudent to allow the user to specify which mode they prefer if both are present, as the REPL font-locking is also hardcoded to |
You might also want to check for inspiration a similar PR for CIDER clojure-emacs/cider#3461 |
> I think it may be prudent to allow the user to specify which mode they prefer if both are present, as the REPL font-locking is also hardcoded to clojure-mode right now. Hi Batsov. For example, if the buffer uses Makes sense? |
If all of the functions exist in I hope this makes sense. |
Cool, I'll implement it. |
@Andre0991 Any updates? |
Add support to
clojure-ts-mode
0.clojure-mode
, I changed it to be aware ofclojure-ts-mode
as well.checkdoc
has a few warnings that already existed before this PR.byte-compile-file
and got no errors or warnings.Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdoc
warningsThanks!