Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to LuaRocks #7

Open
catwell opened this issue Nov 6, 2015 · 5 comments
Open

Add to LuaRocks #7

catwell opened this issue Nov 6, 2015 · 5 comments

Comments

@catwell
Copy link

catwell commented Nov 6, 2015

Would you consider adding a rockspec to this repository and adding this module to LuaRocks?

@ccleung
Copy link

ccleung commented Jan 21, 2016

+1

1 similar comment
@pranas
Copy link

pranas commented Jan 31, 2017

+1

@dndx
Copy link
Contributor

dndx commented Feb 7, 2017

I will try and work on this when available, but if anyone is interested in contributing a PR, fell free :)

@catwell
Copy link
Author

catwell commented Feb 12, 2017

Added one in #17. You may want to change the detailed description.

This is only a SCM rockspec because AFAIK you don't have releases yet. When you want to make an actual versioned release you just have to create a tag like v1.0 and add a corresponding rockspec like this:

 package = "raven"
-version = "scm-1"
+version = "1.0-1"
 
 source = {
-    url = "git://github.com/cloudflare/raven-lua.git"
+    url = "git://github.com/cloudflare/raven-lua.git",
+    branch = "v1.0",
 }

@nevmerzhitsky
Copy link
Contributor

@jdesgats can you or somebody finish the issue? now the package cannot be installed as mentioned in #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants