-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source-based apps should have an SDK intelligently installed #460
Comments
This is not a behavior that I would expect as a .NET developer. .NET defaults to the highest version of SDK installed, and should do the same in the buildpack. As a .NET developer I would expect buildpack to use latest GA version of SDK in buildpack - currently it's 6.x. SDKs are built to be backward compatible as long as necessary target frameworks are installed. For rare scenarios when use of old SDK is required, the user can provide |
@sophiewigmore @ForestEckhardt - please review and close if applicable. |
I think that I agree with @macsux assessment of the situation. Also that mapping has been removed. |
When staging source-based apps that use a non-default version of the SDK, this buildpack should lookup which SDK to install based on the contents of
*.csproj
, removing the requirement to use abuildpack.yml
orglobal.json
to specify the SDK.We do part of this during finalize, where we parse the runtime version from the project.
We could extract that version-gathering logic into a DRYer location and combine it with the runtime->SDK mapping that we maintain in our manifest to go from
*.csproj
-><runtime version>
-><SDK version>
and install that.Here's an example of BRATs using the mapping info to build a go map.
Open questions:
*.fsproj
and*.vbproj
? It seems our buildpack might already handle this (see here and here) without extra code.Relates to #446
The text was updated successfully, but these errors were encountered: