Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDS Instance Relation For Roles #262

Open
mabuaisha opened this issue Jan 17, 2019 · 1 comment
Open

Update RDS Instance Relation For Roles #262

mabuaisha opened this issue Jan 17, 2019 · 1 comment

Comments

@mabuaisha
Copy link

mabuaisha commented Jan 17, 2019

It seems that cloudify.relationships.aws.rds.instance.connected_to relationship for role need to be updated when associating multiple roles with RDS Instance because the current code right now suppose that iam_role_type_key & iam_role_id_key should not be both exists when having relationship with RDS Instance which is wrong and need to be updated

    - type: cloudify.relationships.aws.rds.instance.connected_to
      target: my_monitoring_iam_role
      source_interfaces:
        cloudify.interfaces.relationship_lifecycle:
          preconfigure:
            inputs:
              iam_role_type_key: MonitoringRoleArn
    - type: cloudify.relationships.aws.rds.instance.connected_to
      target: my_domain_iam_role
      source_interfaces:
        cloudify.interfaces.relationship_lifecycle:
          preconfigure:
            inputs:
              iam_role_type_key: DomainIAMRoleName

The code need to be updated so that we can force both attributes to be passed when attaching roles to RDS Instance

Code need to be updated here https://github.com/cloudify-cosmo/cloudify-aws-plugin/blob/master/cloudify_aws/rds/resources/instance.py#L181

And we need also to update the examples https://github.com/cloudify-cosmo/cloudify-aws-plugin/blob/master/examples/rds-feature-demo/blueprint.yaml#L94

@mabuaisha mabuaisha pinned this issue Jan 17, 2019
@EarthmanT
Copy link
Contributor

#RD-2909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants