Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): migrate Select component to TypeScript #571

Merged
merged 18 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-seals-drop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudoperators/juno-ui-components": patch
---

Migrate Select component to typescript
4 changes: 2 additions & 2 deletions packages/ui-components/src/components/Form/Form.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { FormRow } from "../FormRow/index.js"
import { FormSection } from "../FormSection/index.js"
import { FormHint } from "../../deprecated_js/FormHint/index.js"
import { TextInput } from "../../deprecated_js/TextInput/index.js"
import { Select } from "../Select/index.js"
import { SelectOption } from "../SelectOption/index.js"
import { Select } from "../../deprecated_js/Select/index.js"
import { SelectOption } from "../../deprecated_js/SelectOption/index.js"
import { Switch } from "../Switch/index.js"
import { Textarea } from "../../deprecated_js/Textarea/index.js"
import { Button } from "../../deprecated_js/Button/index.js"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const FormHint = ({ children = null, text = "", variant = "help", classNa

FormHint.displayName = "FormHint"

export interface FormHintProps {
export interface FormHintProps extends React.ComponentPropsWithoutRef<"div"> {
/** The children to render as a hint associated with a form element */
children?: ReactNode
/** The text to render. If both children and text are passed, children will rendered */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import React from "react"
import PropTypes from "prop-types"
import { FormRow } from "./index.js"
import { FormRow } from "./FormRow.component"
barsukov marked this conversation as resolved.
Show resolved Hide resolved
import { TextInput } from "../../deprecated_js/TextInput/index.js"

export default {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import React, { useEffect, useState } from "react"
import PropTypes from "prop-types"
import { Button } from "../../deprecated_js/Button/Button.component"
import { TextInput } from "../../deprecated_js/TextInput/TextInput.component"
import { Select } from "../Select/Select.component"
import { SelectOption } from "../SelectOption/SelectOption.component"
import { Select } from "../../deprecated_js/Select/Select.component"
import { SelectOption } from "../../deprecated_js/SelectOption/SelectOption.component"
import { Spinner } from "../../deprecated_js/Spinner/Spinner.component"
import { Stack } from "../../deprecated_js/Stack/Stack.component"

Expand Down
Loading
Loading