Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing target group from http_redirect listener rule #155

Closed
wants to merge 2 commits into from
Closed

Removing target group from http_redirect listener rule #155

wants to merge 2 commits into from

Conversation

mission-ajennings
Copy link

what

  • Removed the target group from being added to http_redirect aws_lb_listener rule.

why

  • This creates a warning on the latest version of AWS Provider (5.35.0) and will eventually cause an error.

references

@mission-ajennings mission-ajennings requested review from a team as code owners February 2, 2024 20:39
@mission-ajennings mission-ajennings requested review from kevcube and woz5999 and removed request for a team February 2, 2024 20:39
@joe-niland
Copy link
Member

Hi @mission-ajennings
Thanks for your contribution.

It seems the readme is out of date. Could you please run the following and commit the result?

make init
make github/init
make readme

@mission-ajennings
Copy link
Author

Hi @mission-ajennings Thanks for your contribution.

It seems the readme is out of date. Could you please run the following and commit the result?

make init
make github/init
make readme

thanks @joe-niland new readme pushed

@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@joe-niland joe-niland requested review from joe-niland and removed request for woz5999 March 4, 2024 03:57
@joe-niland
Copy link
Member

@mission-ajennings apologies, the template has changed recently.
Would you mind repeating that?

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

This pull request is now in conflict. Could you fix it @mission-ajennings? 🙏

@hans-d hans-d added the stale This PR has gone stale label Mar 8, 2024
@mergify mergify bot added the conflict This PR has conflicts label Mar 9, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot closed this Mar 9, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Thanks @mission-ajennings for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the conflict This PR has conflicts label Mar 9, 2024
@osterman
Copy link
Member

osterman commented Mar 10, 2024 •
edited
Loading

@mission-ajennings we're looking into why mergify commented after it was closed. It was closed though due to 30 days inactivity, defined as no new commits. Please re-open if it's still something you can help fix.

@mergify mergify bot removed the stale This PR has gone stale label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_lb_listener.http_redirect Invalid Attribute Combination
4 participants
@mission-ajennings @joe-niland @hans-d @osterman