fix: support for 32-bit ASN #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `customer_gateway_bgp_asn` now automatically sets `bgp_asn` or `bgp_asn_extended` whether the value cannot be represented as a 32-bit number
Gowiem
requested changes
Oct 9, 2024
There was a problem hiding this comment.
@riccardolocci Looks like a fine change, but you'll need to run terraform format and push those changes, otherwise our tests will fail. Do that and I'll re-review.
|
@Gowiem thank you for the comment, I've applied the changes you requested and aligned the PR with the latest commits. |
Gowiem
added
patch
|
/terratest |
Gowiem
previously approved these changes
Oct 12, 2024
|
Hi @Gowiem, I've updated the |
|
💥 This pull request now has conflicts. Could you fix it @riccardolocci? 🙏 |
|
Merged latest changes from main and updated documentation due to AWS provider version update |
|
Hi @Gowiem @nitrocode can you review the code? Thanks! |
|
/terratest |
Gowiem
added
minor
|
Bumping to minor because we're bumping the AWS Provider version. |
|
These changes were released in v1.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
customer_gateway_bgp_asnnow automatically setsbgp_asnorbgp_asn_extendedwhether the value cannot be represented as a 32-bit numberwhat
This PR adds support for ASN numbers greater than
2147483647why
Customer Gateways created by the module only use variable
bgp_asn, which does not support 32-bit integersInstead the
aws_customer_gatewayresource provides a different variable,bgp_asn_extendedwhich is not currently used by the modulereferences
hashicorp/terraform-provider-aws#38738