fix creating namespace

cloudtruth · Jun 17, 2021 · 9db00b4 · 9db00b4
1 parent 5d5646b
commit 9db00b4
Show file tree

Hide file tree

Showing 3 changed files with 188 additions and 15 deletions.
diff --git a/lib/kubetruth/kubeapi.rb b/lib/kubetruth/kubeapi.rb
@@ -56,7 +56,7 @@ def ensure_namespace(ns = namespace)
       rescue Kubeclient::ResourceNotFoundError
         newns = Kubeclient::Resource.new
         newns.metadata = {}
-        newns.metadata.name = namespace
+        newns.metadata.name = ns
         set_managed(newns)
         client.create_namespace(newns)
       end

diff --git a/spec/fixtures/vcr/Kubetruth_KubeApi/ensure_namespace/creates_namespace_if_not_present.yml b/spec/fixtures/vcr/Kubetruth_KubeApi/ensure_namespace/creates_namespace_if_not_present.yml
diff --git a/spec/kubetruth/kubeapi_spec.rb b/spec/kubetruth/kubeapi_spec.rb
@@ -106,6 +106,13 @@ def apiserver; "https://127.0.0.1"; end
         ns = kapi.client.get_namespace(kapi.namespace)
         expect(ns.kind).to eq("Namespace")
         expect(ns.metadata.name).to eq(kapi.namespace)
+
+        newns = "#{namespace}-newns2"
+        expect { kapi.client.get_namespace(newns) }.to raise_error(Kubeclient::ResourceNotFoundError, /namespaces.*not found/)
+        kapi.ensure_namespace(newns)
+        ns = kapi.client.get_namespace(newns)
+        expect(ns.kind).to eq("Namespace")
+        expect(ns.metadata.name).to eq(newns)
       end
 
       it "sets labels when creating namespace" do