feat:(thrift) nested thrift type constructor API #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix021
reviewed
Apr 26, 2024
felix021
reviewed
Apr 28, 2024
felix021
reviewed
Apr 28, 2024
felix021
reviewed
Apr 28, 2024
felix021
reviewed
Apr 28, 2024
| } | ||
| } | ||
| return STRUCT, p.WriteFieldStop() | ||
| default: |
There was a problem hiding this comment.
Suggestion: opensource task for the community to encode arbitrary type with reflection, which supports zero-length slice/map.
There was a problem hiding this comment.
Another approach may be to generate all possible combinations of the types based on go generate with a template to achieve best performance.
felix021
reviewed
Apr 28, 2024
felix021
reviewed
Apr 28, 2024
AsterDY
force-pushed
the
feat/thrift_node_constructor
branch
from
780a3fd
to
70e85df
Compare
AsterDY
force-pushed
the
feat/thrift_node_constructor
branch
from
70e85df
to
24742ca
Compare
felix021
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
NewTypedNode未设置实际内容的问题(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: