Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto/generic/cast.go: let Value struct func <Interface> support Enum… #44

Merged

Conversation

sbs-copilot
Copy link
Contributor

@sbs-copilot sbs-copilot commented Apr 10, 2024

A new optimization

What type of PR is this?

optimize: A new optimization

Check the PR title.

  • This PR title match the format: (optional scope):
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

一个新的优化

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: This PR adds support for extracting the int value contained by an ENUM node.
zh(optional): 本PR新增了对提取ENUM节点并返回int32值的支持。

(Optional) Which issue(s) this PR fixes:

N/A

(optional) The PR that updates user documentation:

N/A

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


shibaoshun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AsterDY
Copy link
Collaborator

AsterDY commented Apr 12, 2024

@sbs-copilot please sign CLA

@AsterDY AsterDY merged commit b93142e into cloudwego:main Apr 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants