Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test is not actually tested #784

Open
kwalcock opened this issue Mar 1, 2023 · 1 comment
Open

Failing test is not actually tested #784

kwalcock opened this issue Mar 1, 2023 · 1 comment
Assignees
@kwalcock

Comments

@kwalcock
Copy link
Member

kwalcock commented Mar 1, 2023

The test

reach/main/src/test/scala/org/clulab/reach/mentions/serialization/TestJSONSerializer.scala

Line 83 in c7397a4

corefmentions.json(true) == JSONSerializer.toCorefMentions(corefmentions.jsonAST).json(true)
doesn't do anything except calculate the value false. It should instead fail. The bug that causes the false value is actually in processors and will be fixed soon. Still, a test should test.
@kwalcock kwalcock self-assigned this Mar 1, 2023
@kwalcock kwalcock mentioned this issue Mar 4, 2023
Closed
@kwalcock
Copy link
Member Author

This is coded and part of a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwalcock kwalcock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwalcock