Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup & render collision after stopping server #17

Open
tomrhollis opened this issue Jul 14, 2020 · 2 comments
Open

Backup & render collision after stopping server #17

tomrhollis opened this issue Jul 14, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@tomrhollis
Copy link
Contributor

OS: Windows
To reproduce:

  1. StopBeforeBackup = true
  2. BackupInterval = RenderInterval
  3. Let the time run out and it takes the server down
  4. It will show two lines of "[ VELLUM ] -> Clearing local world backup directory", and possibly get stuck there

It seems to be a 50/50 coin flip (based on a very small data set) whether this problem will happen, maybe related to which process makes it there first. Sometimes it will stay there forever, and sometimes it will move on to the expected behavior of creating the full world backup, restarting the server, and running the render.

@clvrk
Copy link
Owner

clvrk commented Jul 14, 2020

Thanks again for reporting 🙂!
I will investigate- & implement a way of preventing this! Normally vellum won't (and shouldn't) start a render task if a backup task is already running (and vice-versa), so I will see what's up with that.

@clvrk clvrk added the bug Something isn't working label Sep 24, 2020
@tomrhollis
Copy link
Contributor Author

I haven't seen this happen in a long time. Might be fixed in 1.3. Might be OK to close this, unless it should stay as a reminder for something you're working on

Only slightly related, I'm testing a fix for the other issue of the backup timer acting strange sometimes and will have a PR for that this weekend if the tests go well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants