Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

[feature request] Implement exception handing in RPC callbacks #109

Open
1 task done
jsturdy opened this issue Mar 28, 2019 · 2 comments
Open
1 task done

[feature request] Implement exception handing in RPC callbacks #109

jsturdy opened this issue Mar 28, 2019 · 2 comments

Comments

@jsturdy
Copy link
Contributor

jsturdy commented Mar 28, 2019

Brief summary of issue

To better handle error conditions and unexpected behaviour, we should implement common exception types, and some handlers for cases where a usual course of action needs to be taken.
The RPC method should always be handling the received exceptions and setting the error key in the response message (or handling, if it is appropriate for the method)

Types of issue

  • Feature request (request for change which adds functionality)

Expected Behavior

  • Local methods should not set an error key in the RPCMessage response
  • RPC callbacks should set the error key in the RPCMessage response in the event of an exception or error in the local method

Current Behavior

Some local methods return error codes, some set the error key, and some throw an exception.

@bdorney
Copy link
Contributor

bdorney commented Apr 3, 2019

Isn't this a duplicate issue to #85?

@bdorney
Copy link
Contributor

bdorney commented Apr 3, 2019

Some local methods return error codes, some set the error key, and some throw an exception.

Additionally which methods throw? None come to mind presently. I'm only aware of those that set the error key.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants