Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

[Feature request] Implement a fast Sbits mapping check with the new Sbits hitmap #150

Open
1 of 2 tasks
lpetre-ulb opened this issue Aug 13, 2019 · 0 comments
Open
1 of 2 tasks

Comments

@lpetre-ulb
Copy link
Contributor

Brief summary of issue

The new OH firmware (3.2.6) adds a full-granularity binary Sbit accumulator. Said otherwise, if a Sbit is seen even once during the acquisition period, the Sbit is set to 1 in the hitmap.

This new feature can be used to implement a new Sbit mapping check functionnality which can run quickly (less than 1 minute) and provide precious debugging information.

Types of issue

  • Bug report (report an issue with the code)
  • Feature request (request for change which adds functionality)

Expected Behavior

Leverage the new firmware feature to provide precious Sbits debugging information.

The proposed local function/functor should have the following signature:

std::vector<std::vector<uint32_t>> checkSbitMapping(uint32_t ohN, uint32_t vfatMask, ...usualCalpulseParameters...);

where the external vector is indexed by the pulsed/unmasked Sbit and the internal vector is the Sbit hitmap word is stored in little-endian.

performing the following:

saveState
maskAllChannels
for (channel: channels)
{
    unmask(channel)
    resetHitmap
    pulse(channel)
    readAndStoreHitmap
    mask(channel)
}
restoreState

Current Behavior

The Sbit hitmap is unused.

Context (for feature requests)

The Sbits mapping check currently takes a long time to run. We need a faster Sbit mapping check for debugging and possibly QC.

Moreover it can be the basis of the upcoming Sbits delay scan function.

Also, the Sbit monitor will sooner than later take into account the Sbit mapping while the hitmap will always follow the VFAT channels.

Your Environment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant