Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Feature/sca adc backport #137

Merged

Conversation

mexanick
Copy link
Contributor

@mexanick mexanick commented Jul 5, 2019

Backporting Ram's development to the release/v1.1.X branch

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Required to read out various temperature sensors on the detector

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lpetre-ulb
Copy link
Contributor

As discussed during yesterday DAQ meeting there are changes on the SCA ADC input mapping, so it might be best to wait until the feature/sca-interface branch is patched. I'll open an issue with the list of changes so someone wan work on it.

@mexanick
Copy link
Contributor Author

mexanick commented Jul 5, 2019

@lpetre-ulb I can implement the required changes if you supply me the correct inputs mapping

@lpetre-ulb
Copy link
Contributor

@lpetre-ulb I can implement the required changes if you supply me the correct inputs mapping

@mexanick, I listed the changes made to the OH in this issue. Please let me know if something is unclear.

bdorney
bdorney previously approved these changes Jul 8, 2019
Copy link
Contributor

@bdorney bdorney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a pretty straightforward backport by applying the previously approved commits.

@bdorney
Copy link
Contributor

bdorney commented Jul 11, 2019

rebase needed.

@mexanick
Copy link
Contributor Author

rebased

@mexanick mexanick requested a review from bdorney August 13, 2019 14:20
@mexanick mexanick merged commit ac31ea8 into cms-gem-daq-project:release/v1.1.X Aug 13, 2019
@jsturdy jsturdy mentioned this pull request Dec 6, 2019
1 task
@mexanick mexanick deleted the feature/sca-adc-backport branch March 31, 2020 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants