Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should jetRecalib.py ever be used? #231

Open
adewit opened this issue Feb 5, 2020 · 2 comments
Open

Should jetRecalib.py ever be used? #231

adewit opened this issue Feb 5, 2020 · 2 comments

Comments

@adewit
Copy link
Contributor

adewit commented Feb 5, 2020

In the modules/jme subdirectory there are several tools that appear to do more or less the same thing. I think the syntax from the bottom of jetmetHelperRun2.py should be used (experts can correct me if wrong); if so shouldn't jetRecalib.py (https://github.com/cms-nanoAOD/nanoAOD-tools/blob/master/python/postprocessing/modules/jme/jetRecalib.py ) simply be deleted to avoid people using this (and picking up old JECs unintentionally?)
@adewit
Copy link
Contributor Author

adewit commented Feb 5, 2020

(The same applies for the lambda module definitions in jetmetUncertainties - if they are not to be used probably best to remove?)

@danbarto
Copy link
Contributor

danbarto commented Feb 5, 2020

I agree, we should clear out the JME related tools.
Yes, jetmetHelperRun2 is the recommended tool to use the latest developments and corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adewit @danbarto