RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

iarspider · 2024-06-10T09:11:06Z

In all IBs, GCC emits the following warnings:

>> Building alpaka/serial edm plugin tmp/el8_amd64_gcc12/src/RecoTracker/PixelSeeding/plugins/RecoTrackerPixelSeedingPortableSerialSync/libRecoTrackerPixelSeedingPortableSerialSync.so
(... gcc invocation ...)
In member function 'operator[]',
    inlined from 'size' at src/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h:144:55,
    inlined from 'operator()' at src/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h:553:42,
    inlined from '__invoke_impl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/invoke.h:61:36,
    inlined from '__invoke' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/invoke.h:96:40,
    inlined from '__apply_impl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/tuple:1852:27,
    inlined from 'apply' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/tuple:1863:31,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/kernel/TaskKernelCpuSerial.hpp:92:31,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:25:14,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:44:27,
    inlined from 'ndLoop' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:71:27,
    inlined from 'ndLoopIncIdx' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:83:15,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/kernel/TaskKernelCpuSerial.hpp:86:31:
  src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: warning: array subscript 262145 is above array bounds of 'const unsigned int[262145]' [-Warray-bounds]
    15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];
      |       ^
In member function 'operator[]',
    inlined from 'size' at src/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h:144:55,
    inlined from 'operator()' at src/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h:553:42,
    inlined from '__invoke_impl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/invoke.h:61:36,
    inlined from '__invoke' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/invoke.h:96:40,
    inlined from '__apply_impl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/tuple:1852:27,
    inlined from 'apply' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/tuple:1863:31,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/kernel/TaskKernelCpuSerial.hpp:92:31,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:25:14,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:44:27,
    inlined from 'ndLoop' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:71:27,
    inlined from 'ndLoopIncIdx' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:83:15,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/kernel/TaskKernelCpuSerial.hpp:86:31:
  src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: warning: array subscript 262145 is above array bounds of 'const unsigned int[262145]' [-Warray-bounds]
    15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];
      |       ^
In member function 'operator[]',
    inlined from 'size' at src/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h:144:55,
    inlined from 'operator()' at src/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h:553:42,
    inlined from '__invoke_impl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/invoke.h:61:36,
    inlined from '__invoke' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/invoke.h:96:40,
    inlined from '__apply_impl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/tuple:1852:27,
    inlined from 'apply' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/tuple:1863:31,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/kernel/TaskKernelCpuSerial.hpp:92:31,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:25:14,
    inlined from 'ndLoopImpl' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:44:27,
    inlined from 'ndLoop' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:71:27,
    inlined from 'ndLoopIncIdx' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/meta/NdLoop.hpp:83:15,
    inlined from 'operator()' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/alpaka/1.1.0-0a6641b4bfdf883c8da5b9e8620be504/include/alpaka/kernel/TaskKernelCpuSerial.hpp:86:31:
  src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: warning: array subscript 32769 is above array bounds of 'const unsigned int[32769]' [-Warray-bounds]
    15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];
      |       ^

The text was updated successfully, but these errors were encountered:

cmsbuild · 2024-06-10T09:11:21Z

cms-bot internal usage

cmsbuild · 2024-06-10T09:11:22Z

A new Issue was created by @iarspider.

@antoniovilela, @smuzaffar, @makortel, @rappoccio, @sextonkennedy, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

iarspider · 2024-06-10T09:11:27Z

assign HeterogeneousCore/AlpakaInterface,RecoTracker/PixelSeeding

cmsbuild · 2024-06-10T09:11:46Z

New categories assigned: heterogeneous,reconstruction

@fwyzard,@jfernan2,@makortel,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks

iarspider · 2024-06-10T09:14:44Z

First occurrence in CMSSW_14_1_X_2024-06-05-2300

slava77 · 2024-06-10T13:55:32Z

@AdrianoDee
in case you haven't received this already

Dr15Jones · 2024-06-27T17:49:27Z

This is probably not a real issue. [I think I was wrong initially]

cmssw/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h

Lines 552 to 553 in 64d4f3b

    
           for (auto idx : cms::alpakatools::uniform_elements(acc, tracks_view.hitIndices().nOnes())) { 
        
             if (tracks_view.hitIndices().size(idx) == 0)

with the final line calls

cmssw/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h

Line 144 in 64d4f3b

constexpr auto size(uint32_t b) const { return off[b + 1] - off[b]; }

notice the b+1. The documentation for uniform_elements has

cmssw/HeterogeneousCore/AlpakaInterface/interface/workdivision.h

Lines 254 to 255 in 64d4f3b

    
              * `uniform_elements(acc [, first], extent)` returns a one-dimensional iteratable range that spans the element indices 
        
              * from `first` (inclusive) to `extent` (exlusive).

so the b+1 will be the size of the container so off[b+1] at first glance seems to be off the end of the container.

However, looking at the definition of nOnes()

cmssw/HeterogeneousCore/CUDAUtilities/interface/OneToManyAssoc.h

Line 167 in 64d4f3b

constexpr auto nOnes() const { return totOnes() - 1; }

and

cmssw/HeterogeneousCore/CUDAUtilities/interface/OneToManyAssoc.h

Line 166 in 64d4f3b

constexpr auto totOnes() const { return off.capacity(); }

then assuming capacity is the true size of the container, than off[b+1] for the end condition should be off[ (nOnes()-1) +1] ==off[( (totOnes()-1)-1 ) +1 ] == off[totOnes() -1]

fwyzard · 2024-06-27T18:05:16Z

@Dr15Jones thanks for looking into this issue 👍🏻

VinInn · 2024-06-28T08:05:00Z

yep. All that was indeed intentional (at least in the CUDA version).

smuzaffar · 2024-06-28T12:59:29Z

I have opened #45340 to suppress this error

Dr15Jones · 2024-06-28T16:09:45Z

One more item, if I add

assert(static_cast<decltype(tracks_view.hitIndices().nOnes())>(idx) < tracks_view.hitIndices().nOnes());

right before the call to size the warning goes away. Evidently that helped the link time optimizer to see the index can not go out of bounds. The question is why the optimizer thinks uniform_elements can go out of bounds when given nOnes() as the end point.

Dr15Jones · 2024-06-28T16:48:17Z

A bit more investigation, if I change the loop condition to actually be on the end, i.e.

for (auto idx : cms::alpakatools::uniform_elements(acc, tracks_view.hitIndices().totOnes()))

the warning states that the value goes 1 beyond the end, instead of just the end (which is what is actually going on). So the compiler really thinks that cms::alpakatools::uniform_elements end condition is inclusive instead of exclusive.

slava77 · 2024-07-27T00:05:27Z

is this still active after #45455 and cms-sw/cmsdist#9301 ?

fwyzard · 2024-07-27T05:29:00Z

The warning should be fixed (i.e. disabled).

I would still like to double check our code and make sure the range is correct, and in case try to write a simpler reproducer to submit to gcc.

cmsbuild added the pending-assignment label Jun 10, 2024

cmsbuild added reconstruction-pending pending-signatures heterogeneous-pending tracking and removed pending-assignment labels Jun 10, 2024

smuzaffar added a commit to smuzaffar/cmssw that referenced this issue Jun 28, 2024

[GCC13] Suppress array-bound error cms-sw#45179

013d2db

smuzaffar mentioned this issue Jun 28, 2024

[GCC13] Suppress array-bound error #45179 from PixelSeeding #45340

Closed

fwyzard mentioned this issue Jul 15, 2024

Add a tool to disable the -Warray-bounds flag cms-sw/cmsdist#9301

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

iarspider commented Jun 10, 2024

cmsbuild commented Jun 10, 2024 •

edited

Loading

cmsbuild commented Jun 10, 2024

iarspider commented Jun 10, 2024 •

edited

Loading

cmsbuild commented Jun 10, 2024

iarspider commented Jun 10, 2024

slava77 commented Jun 10, 2024

Dr15Jones commented Jun 27, 2024 •

edited

Loading

fwyzard commented Jun 27, 2024

VinInn commented Jun 28, 2024 •

edited

Loading

smuzaffar commented Jun 28, 2024

Dr15Jones commented Jun 28, 2024

Dr15Jones commented Jun 28, 2024

slava77 commented Jul 27, 2024

fwyzard commented Jul 27, 2024

RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

Comments

iarspider commented Jun 10, 2024

cmsbuild commented Jun 10, 2024 • edited Loading

cmsbuild commented Jun 10, 2024

iarspider commented Jun 10, 2024 • edited Loading

cmsbuild commented Jun 10, 2024

iarspider commented Jun 10, 2024

slava77 commented Jun 10, 2024

Dr15Jones commented Jun 27, 2024 • edited Loading

fwyzard commented Jun 27, 2024

VinInn commented Jun 28, 2024 • edited Loading

smuzaffar commented Jun 28, 2024

Dr15Jones commented Jun 28, 2024

Dr15Jones commented Jun 28, 2024

slava77 commented Jul 27, 2024

fwyzard commented Jul 27, 2024

cmsbuild commented Jun 10, 2024 •

edited

Loading

iarspider commented Jun 10, 2024 •

edited

Loading

Dr15Jones commented Jun 27, 2024 •

edited

Loading

VinInn commented Jun 28, 2024 •

edited

Loading