-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise the EcalElectronicsMappingHost
with null detids
#45209
Initialise the EcalElectronicsMappingHost
with null detids
#45209
Conversation
enable gpu |
please test |
type bugfix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45209/40560
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ecal |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67bb93/39855/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
fixes #44956 |
+1 |
PR description:
Initialise the
EcalElectronicsMappingHost
with null detids explicitly, instead of relying on uninitialised memory.PR validation:
Fixes #44956.
Running the HLT with
export MALLOC_CONF=junk:true
now works.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 14.0.x for data taking.