Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip version hack in gdocs sync GH action #1505

Open
melange396 opened this issue Jul 25, 2024 · 1 comment
Open

Fix pip version hack in gdocs sync GH action #1505

melange396 opened this issue Jul 25, 2024 · 1 comment
Labels
code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc

Comments

@melange396
Copy link
Collaborator

#1503 put a hack into the update_gdocs_data.yml GH action to fix a problem that appeared because of a pip version change. Resolve this in a more proper way.

@melange396 melange396 added dependencies Pull requests that update a dependency file code health readability, maintainability, best practices, etc devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc labels Jul 25, 2024
@dshemetov
Copy link
Contributor

dshemetov commented Jul 25, 2024

  • AFAICT, we can probably replace pip install -r requirements.dev.txt in that action with just pip install invoke requests, since it only needs to run tasks.py
  • the dependency holding back pip is dropbox; I wasn't able to figure out where pip is pinned in that package config, so I can't tell if version 12.0.0 changed that; might be easiest to just test it
  • the only file that needs that dependency is cdc_dropbox_receiver; not sure if that acquisition code runs anymore, but regardless, this makes me wish for isolated envs for acquisition pipelines (related Infra refactor: convert acquisition to an installable package #939)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc
Projects
None yet
Development

No branches or pull requests

2 participants