Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slide profiling compared to various other backends #392

Open
dsweber2 opened this issue Jan 11, 2024 · 3 comments
Open

slide profiling compared to various other backends #392

dsweber2 opened this issue Jan 11, 2024 · 3 comments
Assignees

Comments

@dsweber2
Copy link
Contributor

In exploration tooling, https://github.com/cmu-delphi/exploration-tooling/blob/bbcef76a822c36f78d32669ab7b0461dea7a2302/R/data_transforms.R#L38-L47, the forecasters that use epi_slide to do averaging/sd take ~5-10x as long as those that don't. It is unclear if this is specific to epi_slide or would hold for any method of doing this. Towards that end, we should do some profiling of epi_slide to make sure it isn't significantly slower than comparable methods, specifically for mean and standard deviation calculations.

@nmdefries nmdefries self-assigned this Jan 25, 2024
@nmdefries
Copy link
Contributor

Partially addressed in #397. Adding a specialized rolling mean fn in #400. We discussed and decided that a specialized rolling sd fn was unnecessary.

@nmdefries
Copy link
Contributor

Profile of 7dav on dataset with 3 geos and 400k obs per geo, commit 7ae9e87

profile

@nmdefries
Copy link
Contributor

nmdefries commented Feb 6, 2024

With the current implementation, we're unlikely to make epi_slide much faster. A fair amount of the runtime is slider setup and the actual computation (maybe 1/2-3/4 of total time), plus (lots of) low-level functions that are hard to replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants