Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable signal comparisons on time series plots #1113

Open
ryantibs opened this issue Jan 4, 2022 · 2 comments · May be fixed by #1136
Open

Enable signal comparisons on time series plots #1113

ryantibs opened this issue Jan 4, 2022 · 2 comments · May be fixed by #1136
Labels
dashboard-builder enhancement New feature or request

Comments

@ryantibs
Copy link
Member

ryantibs commented Jan 4, 2022

I'm using the dashboard frequently these days and I'm enjoying all the new fixes & simplifications. One thing that's missing for me is the ability to compare two signals at the same time, overlaid on a single time series plot. See the screenshot below as an example to build from:

Screen Shot 2022-01-04 at 5 11 38 PM

I would like to have a toggle called "Compare Indicators". This could show up, say, on the right-hand side of the plot. If this were toggled on, then it would allow me to select from any of the indicators (that are available at the given location) to put on the same time series plot. The default selection would be nothing.

  • If a single other indicator is selected, then we would get dual y-axes, like the first screenshot below.
  • If multiple other indicators are selected, then we would get signal values scaled to have the same min and max over the observed range, like the second screenshot below.
  • Moving your cursor over the time series would show all values for all signals at the given time value, like the third screenshot below.
  • To be clear, there would be no other locations shown in faint lines anymore (in the current example, no more national, state, and average-of-neighbors curves). This would disappear as soon as we toggle on "Compare Indicators", which would only show the current location.

Screen Shot 2022-01-04 at 5 34 07 PM
Screen Shot 2022-01-04 at 5 40 07 PM
Screen Shot 2022-01-04 at 5 43 43 PM

As a separate idea, we could have another toggle called "Compare Locations". This would show up, say, on the right-hand side o fetch plot again, right above or below "Compare Indicators". If this were toggled on, then it would allow me to select from any of the locations (that are available for the given indicators). The default selection would be whatever the default is for the faint lines; that is, national, parent state, and average-of-neighbors for the current example.

  • I think the y-axis business here would be very simple, we just keep it as is.
  • But the lines here are no longer faint, they are all painted fully/normally.
  • And the hover tips would be as I suggested above in the "Compare Indicators" mode (shows values for all locations).
@ryantibs ryantibs added enhancement New feature or request v3.1 labels Jan 4, 2022
@ryantibs
Copy link
Member Author

ryantibs commented Jan 5, 2022

Few updates: I removed v3.1 because this is quite big and would probably hold up a 3.1 release, and shouldn't.

Also, after speaking with Sam a bit on slack, I think it makes more sense to try this out on the dashboard builder. That will allow us to try it out and see how it works, and see how much we like it.

On the dashboard builder, I think each of these requests: "Compare Indicators" or "Compare Locations" can be enabled simply as allowing the user to select multiple indicators or multiple locations (but not both simultaneously) from the "Add Widget" options.

@sgratzl
Copy link
Member

sgratzl commented Jan 6, 2022

re comparison in dashboard builder:

since the highlights in time series charts are synced you can already do some comparisons:

image

@sgratzl sgratzl linked a pull request Jan 18, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard-builder enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants