Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #1261

Open
melange396 opened this issue Oct 2, 2024 · 0 comments
Open

Add tests #1261

melange396 opened this issue Oct 2, 2024 · 0 comments
Labels
bug Something isn't working chore enhancement New feature or request

Comments

@melange396
Copy link
Contributor

melange396 commented Oct 2, 2024

This repository is very lacking in terms of tests (automated or otherwise), except for the CI action that makes sure it builds. There are exceedingly basic unit tests in https://github.com/cmu-delphi/www-covidcast/blob/dev/src/data/EpiWeek.spec.ts, https://github.com/cmu-delphi/www-covidcast/blob/dev/src/data/utils.spec.ts, and https://github.com/cmu-delphi/www-covidcast/blob/dev/src/stores/constants.spec.ts. A testing environment was introduced in #604 but disabled and deleted somewhere around or between #757 and #972.

New/more unit tests would be nice, and something like integration tests would be fantastic... But at the very least, we should try to include a few [detailed] smoke tests to mimic the manual poking around that a developer or releaser is supposed to do. They could be automatically run against a PR's associated netlify preview. This can help if/when one of us "forgets" to do those manual checks, or neglects doing them thoroughly.

Associated issues in other repos:

@melange396 melange396 added bug Something isn't working enhancement New feature or request chore labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant