Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text artifact from certain pages #1033

Open
melange396 opened this issue Oct 17, 2024 · 0 comments
Open

Remove text artifact from certain pages #1033

melange396 opened this issue Oct 17, 2024 · 0 comments
Labels

Comments

@melange396
Copy link
Contributor

Some pages show a spurious "-->" (which could perhaps be an HTML comment close tag) just under the menu bar at the top of the page. For instance, it can be seen in the current deployment of the epidata/covidcast dashboard and epivis, but not in the blog list or the team page.

It does not appear in https://deploy-preview-1015--cmu-delphi-main.netlify.app/covidcast/

But shows up in https://deploy-preview-1022--cmu-delphi-main.netlify.app/covidcast/

It might have come from the HTML comment addition in themes/delphi/layouts/_default/baseof.html : https://github.com/cmu-delphi/www-main/pull/1022/files#diff-6234b75ca15fff5ac3b2c40b86a94e7fa192e6b90dd3bc21ce348bc98a163e94R11

I thought the breadcrumb thing sounded familiar, so i looked and found a suggestion i made in this comment that might be helpful: #996 (comment)

@melange396 melange396 added the bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant