Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay guessDerived for unresolved possibleDestructors #215

Open
sei-eschwartz opened this issue Feb 18, 2022 · 6 comments
Open

Delay guessDerived for unresolved possibleDestructors #215

sei-eschwartz opened this issue Feb 18, 2022 · 6 comments

Comments

@sei-eschwartz
Copy link
Collaborator

std::_Locinfo and std::_Lockit are super annoying in vs2010/Lite/oo. I think one problem is that we use our guessDerived rule to merge them sometimes before we determine whether or not the called method or calling method are destructors (they are). So maybe we should force a decision on the destructor before we do a merge.

@sei-eschwartz
Copy link
Collaborator Author

I have added an implementation of this to the internal issue211 branch

@sei-eschwartz
Copy link
Collaborator Author

This change seems to have positive benefits, including downstream ones.

@sei-eschwartz
Copy link
Collaborator Author

This needs to be put on a separate branch and tested. It's on issue211_destructorstuff, but that branch also enables some fairly liberal destructor guessing that we probably do not want.

@sei-eschwartz sei-eschwartz changed the title Idea: Delay guessDerived for unresolved possibleDestructors Delay guessDerived for unresolved possibleDestructors Jun 14, 2022
@sei-eschwartz
Copy link
Collaborator Author

Improvements to unit tests in ooex3. Running paper suite tests now.

@sei-eschwartz
Copy link
Collaborator Author

image

@sei-eschwartz
Copy link
Collaborator Author

Some improvements, some deteriorations. Malware seems to be especially bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant