Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbmore CascadeEnrich archetype fails tests #31

Open
danielwojtaszek opened this issue Aug 23, 2021 · 2 comments
Open

mbmore CascadeEnrich archetype fails tests #31

danielwojtaszek opened this issue Aug 23, 2021 · 2 comments

Comments

@danielwojtaszek
Copy link

I've installed Mbmore from https://github.com/CNERG/mbmore but some unit tests for CascadeEnrich failed. I've attached the mbmore_unit_tests output. I have CYCLUS 1.5.5 installed on Ubuntu 16.04.

The mbmore commit info is:

commit da1e0ac
Merge: ab6e40d 5dd271c
Author: Paul Wilson [email protected]
Date: Tue Sep 15 06:27:21 2020 -0500
test_results.txt

@bam241
Copy link
Member

bam241 commented Aug 23, 2021

The last time I check CascadeEnrich was highly experimental...
the main version is Cleary out of date.

my "last" updated branch was CascadeEnrich_PR_branch

The last person working on this was @stompsjo he probably owns the most up-to-date version of it....
I am guessing stompsjo:dU_SWU_correction branch

@stompsjo
Copy link

stompsjo commented Aug 24, 2021

Correct, stompsjo:dU_SWU_correction is my latest development branch. I am not familiar with what currently exists on the main branch. The most recent PR from 14 months ago also noted the failure of these tests before and after the changes of that pull request.

AFAIK stompsjo:dU_SWU_correction passes all unit tests, but several are changed from what is currently on CNERG/mbmore:main. As pure speculation, it is possible that changes made to Cyclus in 1.5.5 or 1.5.4 (released in the past 2 years) are incompatible with the current main branch of mbmore (which is several years without updates).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants