Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package-dir -> package #29

Merged
merged 2 commits into from
Aug 15, 2024
Merged

update package-dir -> package #29

merged 2 commits into from
Aug 15, 2024

Conversation

nimakaviani
Copy link
Contributor

No description provided.

@nimakaviani
update package-dir -> package
ec90232 
Signed-off-by: Nima Kaviani <[email protected]>
elamaran11
elamaran11 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But was wondering why we changed this?

@nimakaviani
Copy link
Contributor Author

because it is not for directories only now. you can pull packages from remote git repositories too. so dir in package dir is irrelevant

nabuskey
nabuskey requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The references to examples/ also need to be removed because they are not valid anymore.

@nimakaviani
Copy link
Contributor Author

ah right. we moved them. will fix

nabuskey
nabuskey approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabuskey nabuskey merged commit 7e0474b into main Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elamaran11 elamaran11 elamaran11 approved these changes

@nabuskey nabuskey nabuskey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimakaviani @nabuskey @elamaran11