Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cli should ignore package names args #182

Merged
merged 2 commits into from
Jan 18, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 17, 2017

closes #181


This change is Reviewable

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @afc163 and @popomore to be potential reviewers.

Copy link
Contributor

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有点粗暴。

没有检查到 package.json 时给个警告如何?

@codecov-io
Copy link

codecov-io commented Jan 17, 2017

Current coverage is 85.36% (diff: 100%)

Merging #182 into master will not change coverage

@@             master       #182   diff @@
==========================================
  Files            19         19          
  Lines          1155       1155          
  Methods          63         63          
  Messages          0          0          
  Branches        222        222          
==========================================
  Hits            986        986          
  Misses          169        169          
  Partials          0          0          

Powered by Codecov. Last update 9f15e53...c3ce9de

@fengmk2
Copy link
Member Author

fengmk2 commented Jan 17, 2017

可以

@fengmk2
Copy link
Member Author

fengmk2 commented Jan 17, 2017

package.json 不存在的时候增加 warn 提示

image

@fengmk2 fengmk2 merged commit 9d4b9d7 into master Jan 18, 2017
@fengmk2 fengmk2 deleted the fix-update-one-package branch January 18, 2017 03:31
@fengmk2
Copy link
Member Author

fengmk2 commented Jan 18, 2017

2.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npminstall update certain package
4 participants