From f579b4c29f2a274b7f2a428c6653491f7566f639 Mon Sep 17 00:00:00 2001 From: Bilal Akhtar Date: Wed, 6 Nov 2024 18:54:37 +0000 Subject: [PATCH] storage: disable multilevel compactions In their current state, multilevel compactions can cause momentary spikes in L0 sublevels, resulting in undesirable side-effects elsewhere. Fixes #134423. Epic: none Release note: None --- pkg/storage/pebble.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/storage/pebble.go b/pkg/storage/pebble.go index 3847dd316260..6d41e1b2f43b 100644 --- a/pkg/storage/pebble.go +++ b/pkg/storage/pebble.go @@ -890,6 +890,10 @@ func DefaultPebbleOptions() *pebble.Options { Lower: EncodeMVCCKey(MVCCKey{Key: keys.LocalRangeLockTablePrefix}), Upper: EncodeMVCCKey(MVCCKey{Key: keys.LocalRangeLockTablePrefix.PrefixEnd()}), } + // Disable multi-level compaction heuristic for now. See #134423 + // for why this was disabled, and what needs to be changed to reenable it. + // This issue tracks re-enablement: https://github.com/cockroachdb/pebble/issues/4139 + opts.Experimental.MultiLevelCompactionHeuristic = pebble.NoMultiLevel{} for i := 0; i < len(opts.Levels); i++ { l := &opts.Levels[i]