Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wal: TestConcurrentWritersWithManyRecords is flaky #4035

Open
RaduBerinde opened this issue Oct 11, 2024 · 3 comments
Open

wal: TestConcurrentWritersWithManyRecords is flaky #4035

RaduBerinde opened this issue Oct 11, 2024 · 3 comments

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Oct 11, 2024

go test -tags invariants --exec 'stress -p 4' -timeout 0 -v ./wal -run TestConcurrentWritersWithManyRecords

=== RUN   TestConcurrentWritersWithManyRecords
    failover_writer_test.go:602: seed: 1728609608940745000
    failover_writer_test.go:716: 
                Error Trace:    /Users/radu/go/src/github.com/cockroachdb/pebble/wal/failover_writer_test.go:716
                                                        /Users/radu/go/src/github.com/cockroachdb/pebble/wal/failover_writer_test.go:720
                Error:          Not equal: 
                                expected: 0
                                actual  : 5373
                Test:           TestConcurrentWritersWithManyRecords

Jira issue: PEBBLE-275

@RaduBerinde
Copy link
Member Author

CC @sumeerbhola - I made a pass at the code but there's too much I'm not familiar with; not sure what can break the assumption that all log files will contain all the records.

@nicktrav nicktrav moved this from Incoming to Tests (failures, skipped, flakes) in [Deprecated] Storage Oct 15, 2024
@itsbilal
Copy link
Member

See past instance of this: #3942

@jbowens
Copy link
Collaborator

jbowens commented Oct 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tests (failures, skipped, flakes)
Development

No branches or pull requests

4 participants