Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 Support #308

Open
nabeeljavaid opened this issue Jun 7, 2022 · 3 comments
Open

Laravel 9 Support #308

nabeeljavaid opened this issue Jun 7, 2022 · 3 comments

Comments

@nabeeljavaid
Copy link

nabeeljavaid commented Jun 7, 2022

Please add Laravel9 support in the package

@bastiaandewaele
Copy link

I am having the same problem here, because another package called cviebrock/eloquent-sluggable uses this one as a dependency :)

When I try updating Laravel 8 to 9 by using composer, I am seeing this error.

 Problem 1
    - laravel/framework[v9.0.0-beta.1, ..., 9.x-dev] require egulias/email-validator ^3.1 -> found egulias/email-validator[3.1.0, ..., 3.x-dev] but the package is fixed to 2.1.25 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - Root composer.json requires laravel/framework ^9.0 -> satisfiable by laravel/framework[v9.0.0-beta.1, ..., 9.x-dev].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

This is because your lock file is stuck at 2.1.25 (egulias/email-validator) and should become ^3.1.

slugify/composer.lock

Lines 383 to 390 in c8c58a2

{
"name": "egulias/email-validator",
"version": "2.1.25",
"source": {
"type": "git",
"url": "https://github.com/egulias/EmailValidator.git",
"reference": "0dbf5d78455d4d6a41d186da50adc1122ec066f4"
},

@florianeckerstorfer
Copy link
Member

I'm happy to merge a Pull Request that addresses this

@bastiaandewaele
Copy link

Ok, great! I will try making the PR next week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants