RestClient support
#3930
Open
RestClient support
#3930
+153
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 19, 2024 07:20
… `RegistrationClient`, this time using `RestClient`.
…ient.Builder` bean is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using
RestClientto register an app, so far onlyRestTemplateorWebClientwere supported.I was trying to follow how the other two are implemented, configured and tested. My app using locally build snapshot version can register itself while having only
RestClientconfigured.As a bonus I fixed one typo. Also I've added logging exceptions when registration fails, it was difficult for me to figure out why registration was failing, when Spring Boot Admin was swallowing exceptions. But feel free to reject that part if you feel like it's too much.
Closes #3906.