Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing dependency on typescript #70

Open
interfect opened this issue Jan 10, 2020 · 2 comments · May be fixed by #71
Open

Missing dependency on typescript #70

interfect opened this issue Jan 10, 2020 · 2 comments · May be fixed by #71

Comments

@interfect
Copy link

interfect commented Jan 10, 2020 •
edited
Loading

@codechecks/[email protected] has a dependency on node-ts ^8.0.2. But [email protected] has a peer dependency on typescript >=2.0, and [email protected] (which is what gets installed today) has a peer dependency on typescript >=2.7.

Since the CodeChecks client module is the one that depends on the module with the peer dependency, as I understand it the CodeChecks client module is the one that is responsible for depending on it as a non-peer dependency. There should be a dependency on typescript >=2.7 to satisfy node-ts, and this dependency needs to be bumped if/when node-ts releases a new version that matches ^8.0.2 and bumps its peer dependency version.

Without this dependency, I get this at the end of npm ls:

npm ERR! peer dep missing: typescript@>=2.7, required by [email protected]
@interfect
Copy link
Author

interfect commented Jan 10, 2020 •
edited
Loading

To reproduce:

npm install --save --dev @codechecks/client
npm ls

interfect added a commit to interfect/codechecks-monorepo that referenced this issue Jan 10, 2020
@interfect
Add typescript to client to satisfy node-ts peer dep
5a30283 
This fixes codechecks#70 by adding a dependency that will pull in typescript, which
node-ts demands as a peer dependency but can't install itself.
@interfect interfect linked a pull request Jan 10, 2020 that will close this issue
Open
@timocov
Copy link

timocov commented Jan 10, 2020

I don't think that ts-node should be in dependencies, it looks strange for me. ts-node usually is used to run typescript code without transpiling locally. @krzkaczor can you please take a look?

@OmgImAlexis OmgImAlexis mentioned this issue Aug 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add typescript to client to satisfy node-ts peer dep interfect/codechecks-monorepo
2 participants
@interfect @timocov