凡例が表示されなくなってしまったのを修正する #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silloi
reviewed
Mar 4, 2021
| li.legend-item(v-for='(setting, name) in map_config.layer_settings' v-if="displayMarkersGroupByCategory.some((elm) => elm.name === name)") | ||
| span.legend-mark(:style="{backgroundColor:setting.color}" @click="selectCategory(name), isOpenList=name, isDisplayAllCategory=false" :class='{open: isDisplayAllCategory || activeCategory === name}') | ||
| li.legend-item(v-for='(setting, category) in map_config.layer_settings' v-if="displayMarkersGroupByCategory.some((elm) => elm.category === category)") | ||
| span.legend-mark(:style="{backgroundColor:setting.color}" @click="selectCategory(category), isOpenList=category, isDisplayAllCategory=false" :class='{open: isDisplayAllCategory || activeCategory === category}') |
There was a problem hiding this comment.
[IMO]なんかここゴチャゴチャっとしているのでtemplateから外出ししたいですね
@click="selectCategory(category), isOpenList=category, isDisplayAllCategory=false"
=>
@click="openCategory(category)"
+追加
openCategory (category) {
this.selectCategory(category)
this.isOpenList = category
this.isDisplayAllCategory = false
},
There was a problem hiding this comment.
このへん読んでても地獄なのでPull Request歓迎です！！！！
There was a problem hiding this comment.
とりあえずissueを立てるとよさそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
動作確認
yarn run devして動くことを確認したスクリーンショット
After
Before