Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pug indent in components/PrintableMap.vue #386

Merged
merged 3 commits into from
Mar 6, 2021

Conversation

takano32
Copy link
Contributor

@takano32 takano32 commented Mar 5, 2021

リファクタリングしようと思ったけど読めなくて心が折れたので、とりあえずインデントした。

読みやすくなった気がするけれど、流儀があっているのかは分からない。

長い部分を script に入れていきたい。

see also. #380

Copy link
Contributor

@silloi silloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これが正しいってわけでもないと思いますが、自分は pug でこう整形してきたのでコメントしました

components/PrintableMap.vue Outdated Show resolved Hide resolved
components/PrintableMap.vue Outdated Show resolved Hide resolved
@takano32
Copy link
Contributor Author

takano32 commented Mar 6, 2021

レビュー、ありがとうございます。

指摘を取り入れたほか、特に長い行については目立つように要素がひとつでもインデントすることにしました。

@yuiseki yuiseki requested a review from silloi March 6, 2021 05:27
Copy link
Collaborator

@yuiseki yuiseki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silloi silloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

反映ありがとうございます! LGTM

@takano32 takano32 merged commit dfda8e4 into codeforjapan:master Mar 6, 2021
@takano32 takano32 deleted the fix-pug-indent branch March 6, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants