Drop Pygments dependency

[jonashaag]

vcs/utils/helpers.py:get_highlighted_code(...) and the vcs/utils/annotate.py module don't seem to be used so it seems to me that the Pygments dependency could be dropped from the install scripts.

[lukaszb]

The problem is that we use pygments at nodes. But yeah, I agree, we should remove it from dependencies...

[jonashaag]

is the lexers attribute required for core functionality? or is it just for some user interface stuff?

[marcinkuzminski]

We use pygments for few things.

• highlight of code for helper functions
• lexers to gues mimetypes

I'm against removing it since core code depends on that.

[jonashaag]

and the mimetype guessing is used for?

[marcinkuzminski]

for determining type of fileNode.
When you fetch a file from repository at given revision method .mimetype will return type of file.

[lukaszb]

It's not the vcs core functionality and I would actually prefer removing it...

Dnia 14 wrz 2011 o godz. 01:22 Marcin Kuźmiń[email protected] napisał(a):

for determining type of fileNode.
When you fetch a file from repository at given revision method .mimetype will return type of file.

Reply to this email directly or view it on GitHub:
#76 (comment)

[marcinkuzminski]

ok, but maybe just do pygment imports in those functions, and raise explanatory exception why ex. "install pygments for this to function" or something like that...

[lukaszb]

That could work, but in fact, it's not core vcs functionality as it's not repository management related. Mimetypes etc should be computed at the higher level.

I'd go with:

1. Remove pygments from deps, raise exception when trying to use pygments-based methods (like mimetype, lexer etc)
2. Mark those methods as deprecated
3. Remove in the next 2 releases (before final release)

[marcinkuzminski]

Sounds good to me.
Marcin Kuzminski

On Fri, Sep 16, 2011 at 13:25, Lukasz Balcerzak
[email protected]
wrote:

That could work, but in fact, it's not core vcs functionality as it's not repository management related. Mimetypes etc should be computed at the higher level.

I'd go with:

1. Remove pygments from deps, raise exception when trying to use pygments-based methods (like mimetype, lexer etc)
2. Mark those methods as deprecated
3. Remove in the next 2 releases (before final release)

Reply to this email directly or view it on GitHub:
#76 (comment)