Escape refresh job for already fresh cache #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walison17
changed the title
walison17
force-pushed
the
refresh-escape
branch
2 times, most recently
from
987d6e8 to
eabb15d
Compare
stephrdev
reviewed
Oct 26, 2021
| @mock.patch('tests.test_base_job.EmptyDummyJob.fetch', return_value='foo') | ||
| def test_escape_job_refresh(self, fetch_mock, rq_burst): | ||
| job = EmptyDummyJob() | ||
| job.task_options = {'is_async': False} |
There was a problem hiding this comment.
What is this option for?
There was a problem hiding this comment.
by default (is_async = True) jobs will be consumed in different threads and call_count don't work properly with many threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a should_refresh method to escape async refresh when the cache is already fresh. This can happen when the worker is slow and there are too many refresh jobs to process.