Replies: 2 comments 3 replies
-
|
Yes we can build this! 👍 |
Beta Was this translation helpful? Give feedback.
-
|
Have a PR up but not happy with that it responds healthy even though the app wasn't working due to bad config. So maybe we should discuss what this health endpoint should verify before responding healthy |
Beta Was this translation helpful? Give feedback.
-
|
In my case it was faulty octokit config. Maybe the solution is to handle errors for octokit and not in health endpoint 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
Yeah. 🤔 One possibility could be to do some sort of octokit command when you hit the endpoint. ¯_(ツ)_/¯ |
Beta Was this translation helpful? Give feedback.
-
|
AFK discussion about this, and we decided that this will be enough for now. Should probably look into improving the octokit setup to add validation |
Beta Was this translation helpful? Give feedback.
-
The docker compose build is successful but the app gets an error. This is because ci-verify.sh script curl to http://localhost:3000
To make sure the docker compose build fails we should create some kind of healthcheck endpoint on the app:
/api/health
or
/api/healthcheck
Beta Was this translation helpful? Give feedback.
All reactions